From fcaaeb51140993fa288b399847c05038c600707e Mon Sep 17 00:00:00 2001
From: LIghtJUNction <lightjunction.me@gmail.com>
Date: Mon, 23 Mar 2026 17:37:14 +0800
Subject: [PATCH] test: fix tests for abstract ComputerBooter

ComputerBooter is now an abstract class, so tests that tried to
instantiate it directly need to be updated:

- test_booter_decoupling.py: remove test_get_tools_delegates_to_class
  since base class cannot be instantiated
- test_profile_aware_tools.py: use ShipyardBooter.__new__() to test
  base class property defaults (capabilities, browser)
- test_computer.py: skip BoxliteBooter test since it's also abstract
  and requires the boxlite module
---
 tests/test_booter_decoupling.py   |  6 ------
 tests/test_profile_aware_tools.py | 14 +++++++++-----
 tests/unit/test_computer.py       |  7 ++++---
 3 files changed, 13 insertions(+), 14 deletions(-)

diff --git a/tests/test_booter_decoupling.py b/tests/test_booter_decoupling.py
index 7bea89bd6..4fbc29bd9 100644
--- a/tests/test_booter_decoupling.py
+++ b/tests/test_booter_decoupling.py
@@ -53,12 +53,6 @@ class TestComputerBooterBaseInterface:
 
         assert ComputerBooter.get_default_tools() == []
 
-    def test_get_tools_delegates_to_class(self):
-        from astrbot.core.computer.booters.base import ComputerBooter
-
-        booter = ComputerBooter()
-        assert booter.get_tools() == []
-
     def test_get_system_prompt_parts_returns_empty(self):
         from astrbot.core.computer.booters.base import ComputerBooter
 
diff --git a/tests/test_profile_aware_tools.py b/tests/test_profile_aware_tools.py
index a9672a8b3..7778bf305 100644
--- a/tests/test_profile_aware_tools.py
+++ b/tests/test_profile_aware_tools.py
@@ -321,16 +321,20 @@ class TestResolveProfile:
 
 
 class TestBaseComputerBooter:
-    """Verify base class defaults."""
+    """Verify base class defaults via subclass."""
 
     def test_capabilities_default_none(self):
-        from astrbot.core.computer.booters.base import ComputerBooter
+        """Test that ComputerBooter base capabilities returns None by default."""
+        from astrbot.core.computer.booters.shipyard import ShipyardBooter
 
-        booter = ComputerBooter()
+        # ShipyardBooter is not abstract, can be instantiated to test defaults
+        booter = ShipyardBooter.__new__(ShipyardBooter)
         assert booter.capabilities is None
 
     def test_browser_default_none(self):
-        from astrbot.core.computer.booters.base import ComputerBooter
+        """Test that ComputerBooter base browser returns None by default."""
+        from astrbot.core.computer.booters.shipyard import ShipyardBooter
 
-        booter = ComputerBooter()
+        # ShipyardBooter is not abstract, can be instantiated to test defaults
+        booter = ShipyardBooter.__new__(ShipyardBooter)
         assert booter.browser is None
diff --git a/tests/unit/test_computer.py b/tests/unit/test_computer.py
index a1b053202..781499a4c 100644
--- a/tests/unit/test_computer.py
+++ b/tests/unit/test_computer.py
@@ -590,6 +590,7 @@ class TestShipyardBooter:
 class TestBoxliteBooter:
     """Tests for BoxliteBooter."""
 
+    @pytest.mark.skip(reason="BoxliteBooter is now abstract and requires boxlite module")
     @pytest.mark.asyncio
     async def test_boxlite_booter_init(self):
         """Test BoxliteBooter can be instantiated via __new__."""
@@ -600,9 +601,9 @@ class TestBoxliteBooter:
         with patch.dict(sys.modules, {"boxlite": mock_boxlite}):
             from astrbot.core.computer.booters.boxlite import BoxliteBooter
 
-            # Just verify class exists and can be instantiated (boot is async)
-            booter = BoxliteBooter.__new__(BoxliteBooter)
-            assert booter is not None
+            # BoxliteBooter is abstract now, cannot instantiate
+            # This test is skipped
+            pass
 
 
 class TestComputerClient: