mirror of
https://github.com/AstrBotDevs/AstrBot
synced 2026-07-16 01:40:15 +08:00
e8d13af5b9
* feat: add TOTP two-factor authentication for dashboard login * fix: ensure TOTP verification uses UTC for accurate time comparison * fix: update recovery code validation logic for disabling TOTP * test: add unit tests for TOTP functionality and recovery code validation * chore: format * feat: add trust_proxy_headers switch for auth rate-limit IP source * feat: make dashboard auth rate-limit configurable via system settings Add auth_rate_limit config block to dashboard settings with enable (default: true), average_interval (default: 1.0s), and max_burst (default: 3) options. The dashboard auth middleware now reads from config instead of using hardcoded values. The average_interval and max_burst fields are conditionally shown only when rate limiting is enabled. * fix: normalize dashboard client IP from trusted proxy headers * refactor: encapsulate rate limiter state into registry, add TTL * feat: show dynamic page title during two-factor verification * fix: require two-factor verification for protected config saves * chore: format * refactor: reorganize TOTP verification UI components for better layout * refactor: clean up recovery stage UI by removing unused styles and improving label handling * docs: add TOTP two-factor authentication documentation for WebUI --------- Co-authored-by: Soulter <905617992@qq.com>
99 lines
3.2 KiB
Python
99 lines
3.2 KiB
Python
import pyotp
|
|
import pytest
|
|
|
|
from astrbot.core.db.sqlite import SQLiteDatabase
|
|
from astrbot.core.utils.totp import (
|
|
consume_totp_code,
|
|
generate_recovery_code,
|
|
is_totp_enabled,
|
|
is_totp_trusted_device_valid,
|
|
issue_totp_trusted_device,
|
|
verify_recovery_code,
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
("totp_config", "expected"),
|
|
[
|
|
({}, False),
|
|
({"enable": False, "secret": "abc", "recovery_code_hash": "hash"}, False),
|
|
({"enable": True, "secret": "", "recovery_code_hash": "hash"}, False),
|
|
({"enable": True, "secret": "abc", "recovery_code_hash": ""}, False),
|
|
({"enable": True, "secret": "abc", "recovery_code_hash": "hash"}, True),
|
|
],
|
|
)
|
|
def test_is_totp_enabled_requires_enable_secret_and_recovery_hash(
|
|
totp_config: dict,
|
|
expected: bool,
|
|
):
|
|
config = {"dashboard": {"totp": totp_config}}
|
|
assert is_totp_enabled(config) is expected
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_consume_totp_code_prevents_replay_same_timecode():
|
|
secret = pyotp.random_base32()
|
|
code = pyotp.TOTP(secret).now()
|
|
assert await consume_totp_code(secret, code) is True
|
|
assert await consume_totp_code(secret, code) is False
|
|
|
|
|
|
def test_generate_and_verify_recovery_code_roundtrip():
|
|
recovery_code, recovery_code_hash = generate_recovery_code()
|
|
config = {"dashboard": {"totp": {"recovery_code_hash": recovery_code_hash}}}
|
|
assert verify_recovery_code(config, recovery_code) is True
|
|
|
|
|
|
def test_verify_recovery_code_rejects_malformed_or_wrong_length():
|
|
recovery_code, recovery_code_hash = generate_recovery_code()
|
|
config = {"dashboard": {"totp": {"recovery_code_hash": recovery_code_hash}}}
|
|
assert verify_recovery_code(config, "abc") is False
|
|
assert verify_recovery_code(config, recovery_code[:-1]) is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_issue_and_validate_trusted_device_token(tmp_path):
|
|
db = SQLiteDatabase(str(tmp_path / "trusted-device.db"))
|
|
config = {
|
|
"dashboard": {
|
|
"jwt_secret": "test-jwt-secret",
|
|
"totp": {
|
|
"enable": True,
|
|
"secret": pyotp.random_base32(),
|
|
"recovery_code_hash": "hash",
|
|
},
|
|
}
|
|
}
|
|
try:
|
|
token = await issue_totp_trusted_device(config, db)
|
|
assert isinstance(token, str) and token
|
|
assert await is_totp_trusted_device_valid(config, db, token) is True
|
|
finally:
|
|
await db.engine.dispose()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_trusted_device_invalid_after_totp_secret_change(tmp_path):
|
|
db = SQLiteDatabase(str(tmp_path / "trusted-device.db"))
|
|
old_secret = pyotp.random_base32()
|
|
new_secret = pyotp.random_base32()
|
|
config = {
|
|
"dashboard": {
|
|
"jwt_secret": "test-jwt-secret",
|
|
"totp": {
|
|
"enable": True,
|
|
"secret": old_secret,
|
|
"recovery_code_hash": "hash",
|
|
},
|
|
}
|
|
}
|
|
try:
|
|
token = await issue_totp_trusted_device(config, db)
|
|
assert isinstance(token, str) and token
|
|
assert await is_totp_trusted_device_valid(config, db, token) is True
|
|
|
|
config["dashboard"]["totp"]["secret"] = new_secret
|
|
assert await is_totp_trusted_device_valid(config, db, token) is False
|
|
finally:
|
|
await db.engine.dispose()
|