mirror of
https://github.com/AstrBotDevs/AstrBot
synced 2026-07-15 17:30:13 +08:00
2c8736fe42
* fix: harden sandbox file transfers * fix: check CUA sandbox availability with shell probe * fix: address sandbox transfer review feedback * fix: preserve CUA health check cancellation * fix: tighten CUA health probe checks
585 lines
16 KiB
Python
585 lines
16 KiB
Python
from __future__ import annotations
|
|
|
|
import base64
|
|
import io
|
|
import zipfile
|
|
from types import SimpleNamespace
|
|
from typing import Any
|
|
from unittest.mock import AsyncMock
|
|
|
|
import pytest
|
|
from mcp.types import CallToolResult, ImageContent
|
|
from PIL import Image
|
|
|
|
from astrbot.core.agent.run_context import ContextWrapper
|
|
from astrbot.core.computer import file_read_utils
|
|
from astrbot.core.computer.booters.local import LocalBooter
|
|
from astrbot.core.tools.computer_tools import fs as fs_tools
|
|
from astrbot.core.tools.computer_tools import util as computer_util
|
|
|
|
|
|
def _make_context(
|
|
*,
|
|
require_admin: bool = True,
|
|
role: str = "admin",
|
|
runtime: str = "local",
|
|
umo: str = "qq:friend:user-1",
|
|
) -> ContextWrapper:
|
|
config_holder = SimpleNamespace(
|
|
get_config=lambda umo=None: {
|
|
"provider_settings": {
|
|
"computer_use_require_admin": require_admin,
|
|
"computer_use_runtime": runtime,
|
|
}
|
|
}
|
|
)
|
|
event = SimpleNamespace(
|
|
role=role,
|
|
unified_msg_origin=umo,
|
|
get_sender_id=lambda: "user-1",
|
|
)
|
|
astr_ctx = SimpleNamespace(context=config_holder, event=event)
|
|
return ContextWrapper(context=astr_ctx)
|
|
|
|
|
|
def _make_sandbox_context(
|
|
*,
|
|
role: str = "admin",
|
|
umo: str = "qq:friend:user-1",
|
|
):
|
|
config_holder = SimpleNamespace(
|
|
get_config=lambda umo=None: {
|
|
"provider_settings": {
|
|
"computer_use_require_admin": True,
|
|
"computer_use_runtime": "sandbox",
|
|
}
|
|
}
|
|
)
|
|
event = SimpleNamespace(
|
|
role=role,
|
|
unified_msg_origin=umo,
|
|
send=AsyncMock(),
|
|
)
|
|
astr_ctx = SimpleNamespace(context=config_holder, event=event)
|
|
return ContextWrapper(context=astr_ctx)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_sandbox_file_download_handles_windows_remote_filename(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
tmp_path,
|
|
):
|
|
temp_root = tmp_path / "temp"
|
|
temp_root.mkdir(parents=True, exist_ok=True)
|
|
|
|
monkeypatch.setattr(
|
|
fs_tools,
|
|
"get_astrbot_temp_path",
|
|
lambda: str(temp_root),
|
|
)
|
|
|
|
async def _download_file(_remote_path, local_path):
|
|
assert local_path.endswith("report.txt")
|
|
assert "\\" not in local_path
|
|
|
|
booter = SimpleNamespace(download_file=AsyncMock(side_effect=_download_file))
|
|
|
|
async def _fake_get_booter(_ctx, _umo):
|
|
return booter
|
|
|
|
monkeypatch.setattr(fs_tools, "get_booter", _fake_get_booter)
|
|
|
|
context = _make_sandbox_context()
|
|
result = await fs_tools.FileDownloadTool().call(
|
|
context,
|
|
remote_path=r"C:\Users\AstrBot\report.txt",
|
|
also_send_to_user=True,
|
|
)
|
|
|
|
assert "report.txt" in result
|
|
sent_chain = context.context.event.send.await_args.args[0]
|
|
sent_file = sent_chain.chain[0]
|
|
assert sent_file.name == "report.txt"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_sandbox_file_download_strips_trailing_remote_slash(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
tmp_path,
|
|
):
|
|
temp_root = tmp_path / "temp"
|
|
temp_root.mkdir(parents=True, exist_ok=True)
|
|
|
|
monkeypatch.setattr(
|
|
fs_tools,
|
|
"get_astrbot_temp_path",
|
|
lambda: str(temp_root),
|
|
)
|
|
|
|
booter = SimpleNamespace(download_file=AsyncMock())
|
|
|
|
async def _fake_get_booter(_ctx, _umo):
|
|
return booter
|
|
|
|
monkeypatch.setattr(fs_tools, "get_booter", _fake_get_booter)
|
|
|
|
context = _make_sandbox_context()
|
|
result = await fs_tools.FileDownloadTool().call(
|
|
context,
|
|
remote_path="reports/export/",
|
|
also_send_to_user=True,
|
|
)
|
|
|
|
assert "export" in result
|
|
sent_chain = context.context.event.send.await_args.args[0]
|
|
sent_file = sent_chain.chain[0]
|
|
assert sent_file.name == "export"
|
|
|
|
|
|
def _setup_local_fs_tools(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
tmp_path,
|
|
*,
|
|
umo: str = "qq:friend:user-1",
|
|
) -> Any:
|
|
workspaces_root = tmp_path / "workspaces"
|
|
skills_root = tmp_path / "skills"
|
|
plugins_root = tmp_path / "plugins"
|
|
temp_root = tmp_path / "temp"
|
|
workspaces_root.mkdir()
|
|
skills_root.mkdir()
|
|
plugins_root.mkdir()
|
|
temp_root.mkdir()
|
|
|
|
monkeypatch.setattr(
|
|
computer_util,
|
|
"get_astrbot_workspaces_path",
|
|
lambda: str(workspaces_root),
|
|
)
|
|
monkeypatch.setattr(
|
|
fs_tools,
|
|
"get_astrbot_skills_path",
|
|
lambda: str(skills_root),
|
|
)
|
|
monkeypatch.setattr(
|
|
fs_tools,
|
|
"get_astrbot_plugin_path",
|
|
lambda: str(plugins_root),
|
|
)
|
|
monkeypatch.setattr(
|
|
fs_tools,
|
|
"get_astrbot_temp_path",
|
|
lambda: str(temp_root),
|
|
)
|
|
monkeypatch.setattr(
|
|
file_read_utils,
|
|
"get_astrbot_temp_path",
|
|
lambda: str(temp_root),
|
|
)
|
|
|
|
booter = LocalBooter()
|
|
|
|
async def _fake_get_booter(_ctx, _umo):
|
|
return booter
|
|
|
|
monkeypatch.setattr(fs_tools, "get_booter", _fake_get_booter)
|
|
|
|
normalized_umo = computer_util.normalize_umo_for_workspace(umo)
|
|
workspace = workspaces_root / normalized_umo
|
|
workspace.mkdir(parents=True, exist_ok=True)
|
|
return workspace
|
|
|
|
|
|
def _make_large_text() -> str:
|
|
return "".join(f"line-{index:05d}-{'x' * 48}\n" for index in range(6000))
|
|
|
|
|
|
def _make_epub_bytes(*, chapter_count: int = 1) -> bytes:
|
|
manifest_items = [
|
|
'<item id="nav" href="nav.xhtml" media-type="application/xhtml+xml" properties="nav"/>'
|
|
]
|
|
spine_items = ['<itemref idref="nav"/>']
|
|
nav_links = []
|
|
|
|
buffer = io.BytesIO()
|
|
with zipfile.ZipFile(buffer, mode="w") as archive:
|
|
archive.writestr(
|
|
"mimetype",
|
|
"application/epub+zip",
|
|
compress_type=zipfile.ZIP_STORED,
|
|
)
|
|
archive.writestr(
|
|
"META-INF/container.xml",
|
|
"""<?xml version="1.0" encoding="UTF-8"?>
|
|
<container version="1.0" xmlns="urn:oasis:names:tc:opendocument:xmlns:container">
|
|
<rootfiles>
|
|
<rootfile full-path="OEBPS/content.opf" media-type="application/oebps-package+xml"/>
|
|
</rootfiles>
|
|
</container>
|
|
""",
|
|
)
|
|
|
|
for index in range(1, chapter_count + 1):
|
|
manifest_items.append(
|
|
f'<item id="chapter{index}" href="chapter{index}.xhtml" '
|
|
'media-type="application/xhtml+xml"/>'
|
|
)
|
|
spine_items.append(f'<itemref idref="chapter{index}"/>')
|
|
nav_links.append(
|
|
f'<li><a href="chapter{index}.xhtml">Chapter {index}</a></li>'
|
|
)
|
|
archive.writestr(
|
|
f"OEBPS/chapter{index}.xhtml",
|
|
f"""<?xml version="1.0" encoding="utf-8"?>
|
|
<html xmlns="http://www.w3.org/1999/xhtml">
|
|
<head>
|
|
<title>Chapter {index}</title>
|
|
</head>
|
|
<body>
|
|
<h1>Chapter {index}</h1>
|
|
<p>Paragraph {index}</p>
|
|
</body>
|
|
</html>
|
|
""",
|
|
)
|
|
|
|
archive.writestr(
|
|
"OEBPS/nav.xhtml",
|
|
"""<?xml version="1.0" encoding="utf-8"?>
|
|
<html xmlns="http://www.w3.org/1999/xhtml">
|
|
<head>
|
|
<title>Navigation</title>
|
|
</head>
|
|
<body>
|
|
<nav epub:type="toc" xmlns:epub="http://www.idpf.org/2007/ops">
|
|
<ol>
|
|
{links}
|
|
</ol>
|
|
</nav>
|
|
</body>
|
|
</html>
|
|
""".format(links="".join(nav_links)),
|
|
)
|
|
archive.writestr(
|
|
"OEBPS/content.opf",
|
|
"""<?xml version="1.0" encoding="UTF-8"?>
|
|
<package xmlns="http://www.idpf.org/2007/opf" version="3.0" unique-identifier="bookid">
|
|
<metadata xmlns:dc="http://purl.org/dc/elements/1.1/">
|
|
<dc:identifier id="bookid">test-book</dc:identifier>
|
|
<dc:title>Test Book</dc:title>
|
|
<dc:language>en</dc:language>
|
|
</metadata>
|
|
<manifest>
|
|
{manifest}
|
|
</manifest>
|
|
<spine>
|
|
{spine}
|
|
</spine>
|
|
</package>
|
|
""".format(
|
|
manifest="".join(manifest_items),
|
|
spine="".join(spine_items),
|
|
),
|
|
)
|
|
|
|
return buffer.getvalue()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_restricted_local_member_can_read_plugin_provided_skill(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
tmp_path,
|
|
):
|
|
_setup_local_fs_tools(monkeypatch, tmp_path)
|
|
plugin_skill = (
|
|
tmp_path
|
|
/ "plugins"
|
|
/ "astrbot_plugin_demo"
|
|
/ "skills"
|
|
/ "demo-skill"
|
|
/ "SKILL.md"
|
|
)
|
|
plugin_skill.parent.mkdir(parents=True)
|
|
plugin_skill.write_text("# Demo Skill\n\nRead plugin docs.", encoding="utf-8")
|
|
|
|
result = await fs_tools.FileReadTool().call(
|
|
_make_context(role="member"),
|
|
path=str(plugin_skill),
|
|
)
|
|
|
|
assert result == "# Demo Skill\n\nRead plugin docs."
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_restricted_local_member_can_read_plugin_skill_inventory_even_if_plugin_inactive(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
tmp_path,
|
|
):
|
|
_setup_local_fs_tools(monkeypatch, tmp_path)
|
|
plugin_skill = (
|
|
tmp_path
|
|
/ "plugins"
|
|
/ "astrbot_plugin_demo"
|
|
/ "skills"
|
|
/ "demo-skill"
|
|
/ "SKILL.md"
|
|
)
|
|
plugin_skill.parent.mkdir(parents=True)
|
|
plugin_skill.write_text("# Demo Skill\n", encoding="utf-8")
|
|
|
|
result = await fs_tools.FileReadTool().call(
|
|
_make_context(role="member"),
|
|
path=str(plugin_skill),
|
|
)
|
|
|
|
assert result == "# Demo Skill\n"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_restricted_local_member_cannot_write_plugin_provided_skill(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
tmp_path,
|
|
):
|
|
_setup_local_fs_tools(monkeypatch, tmp_path)
|
|
plugin_skill = (
|
|
tmp_path
|
|
/ "plugins"
|
|
/ "astrbot_plugin_demo"
|
|
/ "skills"
|
|
/ "demo-skill"
|
|
/ "SKILL.md"
|
|
)
|
|
plugin_skill.parent.mkdir(parents=True)
|
|
plugin_skill.write_text("# Demo Skill\n", encoding="utf-8")
|
|
|
|
result = await fs_tools.FileWriteTool().call(
|
|
_make_context(role="member"),
|
|
path=str(plugin_skill),
|
|
content="# Changed\n",
|
|
)
|
|
|
|
assert "Write access is restricted for this user." in result
|
|
assert "data/plugins/*/skills" not in result
|
|
assert plugin_skill.read_text(encoding="utf-8") == "# Demo Skill\n"
|
|
|
|
|
|
def test_detect_text_encoding_allows_utf8_probe_cut_mid_character():
|
|
sample = '{"results": ["中文内容"]}'.encode()[:-1]
|
|
|
|
assert file_read_utils.detect_text_encoding(sample) in {"utf-8", "utf-8-sig"}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_file_read_tool_rejects_large_full_text_read_before_local_stream_read(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
tmp_path,
|
|
):
|
|
workspace = _setup_local_fs_tools(monkeypatch, tmp_path)
|
|
large_file = workspace / "large.txt"
|
|
large_file.write_text(_make_large_text(), encoding="utf-8")
|
|
|
|
async def _unexpected_read(*args, **kwargs):
|
|
raise AssertionError("full file read should be rejected before streaming")
|
|
|
|
monkeypatch.setattr(file_read_utils, "read_local_text_range", _unexpected_read)
|
|
|
|
result = await fs_tools.FileReadTool().call(
|
|
_make_context(),
|
|
path="large.txt",
|
|
)
|
|
|
|
assert "text file exceeds 262144 bytes" in result
|
|
assert "Use `offset` and `limit`" in result
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_file_read_tool_allows_partial_read_for_large_text_file(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
tmp_path,
|
|
):
|
|
workspace = _setup_local_fs_tools(monkeypatch, tmp_path)
|
|
large_file = workspace / "large.txt"
|
|
lines = [f"line-{index:05d}\n" for index in range(50000)]
|
|
large_file.write_text("".join(lines), encoding="utf-8")
|
|
|
|
result = await fs_tools.FileReadTool().call(
|
|
_make_context(),
|
|
path="large.txt",
|
|
offset=1000,
|
|
limit=3,
|
|
)
|
|
|
|
assert result == "".join(lines[1000:1003])
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_file_read_tool_returns_image_call_tool_result_for_images(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
tmp_path,
|
|
):
|
|
workspace = _setup_local_fs_tools(monkeypatch, tmp_path)
|
|
image_path = workspace / "sample.png"
|
|
Image.new("RGB", (32, 16), color=(255, 0, 0)).save(image_path, format="PNG")
|
|
|
|
result = await fs_tools.FileReadTool().call(
|
|
_make_context(),
|
|
path="sample.png",
|
|
)
|
|
|
|
assert isinstance(result, CallToolResult)
|
|
assert len(result.content) == 1
|
|
assert isinstance(result.content[0], ImageContent)
|
|
assert result.content[0].mimeType == "image/jpeg"
|
|
assert base64.b64decode(result.content[0].data).startswith(b"\xff\xd8\xff")
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_file_read_tool_treats_svg_as_text(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
tmp_path,
|
|
):
|
|
workspace = _setup_local_fs_tools(monkeypatch, tmp_path)
|
|
svg_path = workspace / "shape.svg"
|
|
svg_text = (
|
|
"<svg xmlns='http://www.w3.org/2000/svg'><rect width='10' height='10'/></svg>"
|
|
)
|
|
svg_path.write_text(svg_text, encoding="utf-8")
|
|
|
|
result = await fs_tools.FileReadTool().call(
|
|
_make_context(),
|
|
path="shape.svg",
|
|
)
|
|
|
|
assert result == svg_text
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_file_read_tool_reads_pdf_via_parser(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
tmp_path,
|
|
):
|
|
workspace = _setup_local_fs_tools(monkeypatch, tmp_path)
|
|
pdf_path = workspace / "doc.pdf"
|
|
pdf_path.write_bytes(b"%PDF-1.7\n%\xe2\xe3\xcf\xd3\n1 0 obj\n<<>>\nendobj\n")
|
|
|
|
async def _fake_parse_pdf(_file_bytes: bytes, _file_name: str) -> str:
|
|
return "page-1\npage-2\n"
|
|
|
|
monkeypatch.setattr(file_read_utils, "_parse_local_pdf_text", _fake_parse_pdf)
|
|
|
|
result = await fs_tools.FileReadTool().call(
|
|
_make_context(),
|
|
path="doc.pdf",
|
|
)
|
|
|
|
assert result == "page-1\npage-2\n"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_file_read_tool_reads_docx_via_parser_and_magic(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
tmp_path,
|
|
):
|
|
workspace = _setup_local_fs_tools(monkeypatch, tmp_path)
|
|
docx_path = workspace / "report.bin"
|
|
buffer = io.BytesIO()
|
|
with zipfile.ZipFile(buffer, mode="w") as archive:
|
|
archive.writestr("[Content_Types].xml", "<Types/>")
|
|
archive.writestr("word/document.xml", "<w:document/>")
|
|
docx_path.write_bytes(buffer.getvalue())
|
|
|
|
async def _fake_parse_docx(_file_bytes: bytes, _file_name: str) -> str:
|
|
return "doc-line-1\ndoc-line-2\n"
|
|
|
|
monkeypatch.setattr(file_read_utils, "_parse_local_docx_text", _fake_parse_docx)
|
|
|
|
result = await fs_tools.FileReadTool().call(
|
|
_make_context(),
|
|
path="report.bin",
|
|
)
|
|
|
|
assert result == "doc-line-1\ndoc-line-2\n"
|
|
|
|
|
|
def test_is_epub_bytes_rejects_plain_zip_archive():
|
|
buffer = io.BytesIO()
|
|
with zipfile.ZipFile(buffer, mode="w") as archive:
|
|
archive.writestr("README.txt", "hello")
|
|
|
|
assert file_read_utils._is_epub_bytes(buffer.getvalue()) is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_file_read_tool_reads_epub_via_parser_and_magic(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
tmp_path,
|
|
):
|
|
workspace = _setup_local_fs_tools(monkeypatch, tmp_path)
|
|
epub_path = workspace / "novel.bin"
|
|
epub_path.write_bytes(_make_epub_bytes(chapter_count=2))
|
|
|
|
async def _fake_parse_epub(_file_bytes: bytes, _file_name: str) -> str:
|
|
return "# Chapter 1\n\nParagraph 1\n"
|
|
|
|
monkeypatch.setattr(file_read_utils, "_parse_local_epub_text", _fake_parse_epub)
|
|
|
|
result = await fs_tools.FileReadTool().call(
|
|
_make_context(),
|
|
path="novel.bin",
|
|
)
|
|
|
|
assert result == "# Chapter 1\n\nParagraph 1\n"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_file_read_tool_stores_long_converted_document_in_workspace(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
tmp_path,
|
|
):
|
|
workspace = _setup_local_fs_tools(monkeypatch, tmp_path)
|
|
pdf_path = workspace / "manual.pdf"
|
|
pdf_path.write_bytes(b"%PDF-1.7\nfake\n")
|
|
long_text = _make_large_text()
|
|
|
|
async def _fake_parse_pdf(_file_bytes: bytes, _file_name: str) -> str:
|
|
return long_text
|
|
|
|
monkeypatch.setattr(file_read_utils, "_parse_local_pdf_text", _fake_parse_pdf)
|
|
|
|
result = await fs_tools.FileReadTool().call(
|
|
_make_context(),
|
|
path="manual.pdf",
|
|
)
|
|
|
|
converted_root = workspace / "converted_files"
|
|
converted_files = list(converted_root.glob("manual.pdf_*/text.txt"))
|
|
assert len(converted_files) == 1
|
|
assert converted_files[0].read_text(encoding="utf-8") == long_text
|
|
assert str(converted_files[0]) in result
|
|
assert "Read or grep that file with a narrow window." in result
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_grep_tool_applies_result_limit(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
tmp_path,
|
|
):
|
|
workspace = _setup_local_fs_tools(monkeypatch, tmp_path)
|
|
text_path = workspace / "grep.txt"
|
|
text_path.write_text(
|
|
"match-1\nmatch-2\nmatch-3\nmatch-4\n",
|
|
encoding="utf-8",
|
|
)
|
|
|
|
result = await fs_tools.GrepTool().call(
|
|
_make_context(),
|
|
pattern="match",
|
|
path="grep.txt",
|
|
result_limit=2,
|
|
)
|
|
|
|
assert "match-1" in result
|
|
assert "match-2" in result
|
|
assert "match-3" not in result
|
|
assert "[Truncated to first 2 result groups.]" in result
|