mirror of
https://github.com/AstrBotDevs/AstrBot
synced 2026-07-16 01:40:15 +08:00
f3aa2a6959
* perf: optimize plugin list merge * fix: guard plugin list directory iteration * test: move plugin utils tests to unit suite * fix: minimize plugin path guard change * test: cover missing plugin directory listing * fix: address code review feedback on plugin utils and tests * perf: optimize plugin comparison using dict pop method * style: format plugin.py and retry CI
111 lines
3.8 KiB
Python
111 lines
3.8 KiB
Python
from pathlib import Path
|
|
|
|
from astrbot.cli.utils.plugin import PluginStatus, build_plug_list
|
|
|
|
|
|
class FakeResponse:
|
|
def raise_for_status(self):
|
|
return None
|
|
|
|
def json(self):
|
|
return {
|
|
"local-plugin": {
|
|
"desc": "remote description",
|
|
"version": "2.0.0",
|
|
"author": "remote-author",
|
|
"repo": "https://example.com/local-plugin",
|
|
},
|
|
"remote-only": {
|
|
"desc": "remote only",
|
|
"version": "1.0.0",
|
|
"author": "remote-author",
|
|
"repo": "https://example.com/remote-only",
|
|
},
|
|
}
|
|
|
|
|
|
class FakeClient:
|
|
def __enter__(self):
|
|
return self
|
|
|
|
def __exit__(self, exc_type, exc, tb):
|
|
return False
|
|
|
|
def get(self, url):
|
|
assert url == "https://api.soulter.top/astrbot/plugins"
|
|
return FakeResponse()
|
|
|
|
|
|
def write_metadata(plugin_dir: Path, name: str, version: str) -> None:
|
|
plugin_dir.mkdir(parents=True, exist_ok=True)
|
|
plugin_dir.joinpath("metadata.yaml").write_text(
|
|
f"""
|
|
name: {name}
|
|
desc: local description
|
|
version: {version}
|
|
author: local-author
|
|
repo: https://example.com/{name}
|
|
""".strip(),
|
|
encoding="utf-8",
|
|
)
|
|
|
|
|
|
def test_build_plug_list_merges_local_and_remote_plugins(monkeypatch, tmp_path):
|
|
write_metadata(tmp_path / "local-plugin", "local-plugin", "1.0.0")
|
|
write_metadata(tmp_path / "unpublished-plugin", "unpublished-plugin", "1.0.0")
|
|
tmp_path.joinpath("ignored-file").write_text("not a plugin", encoding="utf-8")
|
|
|
|
monkeypatch.setattr("astrbot.cli.utils.plugin.httpx.Client", FakeClient)
|
|
|
|
plugins = build_plug_list(tmp_path)
|
|
plugins_by_name = {plugin["name"]: plugin for plugin in plugins}
|
|
|
|
assert plugins_by_name["local-plugin"]["status"] == PluginStatus.NEED_UPDATE
|
|
assert plugins_by_name["unpublished-plugin"]["status"] == PluginStatus.NOT_PUBLISHED
|
|
assert plugins_by_name["remote-only"]["status"] == PluginStatus.NOT_INSTALLED
|
|
assert len(plugins) == 3
|
|
|
|
|
|
def test_build_plug_list_treats_file_plugin_path_as_empty_local_set(
|
|
monkeypatch, tmp_path
|
|
):
|
|
plugins_file = tmp_path / "plugins"
|
|
plugins_file.write_text("not a directory", encoding="utf-8")
|
|
|
|
monkeypatch.setattr("astrbot.cli.utils.plugin.httpx.Client", FakeClient)
|
|
|
|
plugins = build_plug_list(plugins_file)
|
|
|
|
assert [plugin["name"] for plugin in plugins] == ["local-plugin", "remote-only"]
|
|
assert all(plugin["status"] == PluginStatus.NOT_INSTALLED for plugin in plugins)
|
|
|
|
|
|
def test_build_plug_list_local_version_equal_or_newer(monkeypatch, tmp_path):
|
|
monkeypatch.setattr("astrbot.cli.utils.plugin.httpx.Client", FakeClient)
|
|
|
|
# 1. test if local version == remote version
|
|
dir_equal = tmp_path / "dir_equal"
|
|
write_metadata(dir_equal / "local-plugin", "local-plugin", "2.0.0")
|
|
|
|
plugins_equal = build_plug_list(dir_equal)
|
|
plugins_equal_by_name = {p["name"]: p for p in plugins_equal}
|
|
assert plugins_equal_by_name["local-plugin"]["status"] == PluginStatus.INSTALLED
|
|
|
|
# 2. test if local version > remote version
|
|
dir_newer = tmp_path / "dir_newer"
|
|
write_metadata(dir_newer / "local-plugin", "local-plugin", "3.0.0")
|
|
|
|
plugins_newer = build_plug_list(dir_newer)
|
|
plugins_newer_by_name = {p["name"]: p for p in plugins_newer}
|
|
assert plugins_newer_by_name["local-plugin"]["status"] == PluginStatus.INSTALLED
|
|
|
|
|
|
def test_build_plug_list_non_existent_path(monkeypatch, tmp_path):
|
|
non_existent_dir = tmp_path / "completely_non_existent_path"
|
|
|
|
monkeypatch.setattr("astrbot.cli.utils.plugin.httpx.Client", FakeClient)
|
|
|
|
plugins = build_plug_list(non_existent_dir)
|
|
|
|
assert [plugin["name"] for plugin in plugins] == ["local-plugin", "remote-only"]
|
|
assert all(plugin["status"] == PluginStatus.NOT_INSTALLED for plugin in plugins) |