From 809453e40a47ac0df302230672bb4435e6a6da99 Mon Sep 17 00:00:00 2001 From: zzyyyl Date: Tue, 11 Oct 2022 19:23:15 +0800 Subject: [PATCH] perf: std::move string Co-authored-by: MistEO --- src/MeoAssistant/Task/Plugin/RoguelikeBattleTaskPlugin.cpp | 2 +- src/MeoAssistant/Task/Plugin/RoguelikeControlTaskPlugin.cpp | 2 +- src/MeoAssistant/Task/Plugin/RoguelikeCustomStartTaskPlugin.cpp | 2 +- src/MeoAssistant/Task/Plugin/RoguelikeDebugTaskPlugin.cpp | 2 +- src/MeoAssistant/Task/Plugin/RoguelikeFormationTaskPlugin.cpp | 2 +- src/MeoAssistant/Task/Plugin/RoguelikeRecruitTaskPlugin.cpp | 2 +- src/MeoAssistant/Task/Plugin/RoguelikeResetTaskPlugin.cpp | 2 +- src/MeoAssistant/Task/Plugin/RoguelikeShoppingTaskPlugin.cpp | 2 +- .../Task/Plugin/RoguelikeSkillSelectionTaskPlugin.cpp | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/MeoAssistant/Task/Plugin/RoguelikeBattleTaskPlugin.cpp b/src/MeoAssistant/Task/Plugin/RoguelikeBattleTaskPlugin.cpp index c191531717..ad71f5de85 100644 --- a/src/MeoAssistant/Task/Plugin/RoguelikeBattleTaskPlugin.cpp +++ b/src/MeoAssistant/Task/Plugin/RoguelikeBattleTaskPlugin.cpp @@ -29,7 +29,7 @@ bool asst::RoguelikeBattleTaskPlugin::verify(AsstMsg msg, const json::value& det if (!roguelike_name_opt) { return false; } - const auto& roguelike_name = roguelike_name_opt.value() + "@"; + const std::string roguelike_name = std::move(roguelike_name_opt.value()) + "@"; const std::string& task = details.get("details", "task", ""); std::string_view task_view = task; if (task_view.starts_with(roguelike_name)) { diff --git a/src/MeoAssistant/Task/Plugin/RoguelikeControlTaskPlugin.cpp b/src/MeoAssistant/Task/Plugin/RoguelikeControlTaskPlugin.cpp index e7288d17a0..b9a7a679fe 100644 --- a/src/MeoAssistant/Task/Plugin/RoguelikeControlTaskPlugin.cpp +++ b/src/MeoAssistant/Task/Plugin/RoguelikeControlTaskPlugin.cpp @@ -16,7 +16,7 @@ bool asst::RoguelikeControlTaskPlugin::verify(AsstMsg msg, const json::value& de if (!roguelike_name_opt) { return false; } - const auto& roguelike_name = roguelike_name_opt.value() + "@"; + const std::string roguelike_name = std::move(roguelike_name_opt.value()) + "@"; const std::string& task = details.get("details", "task", ""); std::string_view task_view = task; if (task_view.starts_with(roguelike_name)) { diff --git a/src/MeoAssistant/Task/Plugin/RoguelikeCustomStartTaskPlugin.cpp b/src/MeoAssistant/Task/Plugin/RoguelikeCustomStartTaskPlugin.cpp index fc3220a6f2..3462535474 100644 --- a/src/MeoAssistant/Task/Plugin/RoguelikeCustomStartTaskPlugin.cpp +++ b/src/MeoAssistant/Task/Plugin/RoguelikeCustomStartTaskPlugin.cpp @@ -18,7 +18,7 @@ bool asst::RoguelikeCustomStartTaskPlugin::verify(AsstMsg msg, const json::value if (!roguelike_name_opt) { return false; } - const auto& roguelike_name = roguelike_name_opt.value() + "@"; + const std::string roguelike_name = std::move(roguelike_name_opt.value()) + "@"; const std::string& task = details.get("details", "task", ""); std::string_view task_view = task; if (task_view.starts_with(roguelike_name)) { diff --git a/src/MeoAssistant/Task/Plugin/RoguelikeDebugTaskPlugin.cpp b/src/MeoAssistant/Task/Plugin/RoguelikeDebugTaskPlugin.cpp index c2926a3a32..34ff99e3f3 100644 --- a/src/MeoAssistant/Task/Plugin/RoguelikeDebugTaskPlugin.cpp +++ b/src/MeoAssistant/Task/Plugin/RoguelikeDebugTaskPlugin.cpp @@ -17,7 +17,7 @@ bool asst::RoguelikeDebugTaskPlugin::verify(AsstMsg msg, const json::value& deta if (!roguelike_name_opt) { return false; } - const auto& roguelike_name = roguelike_name_opt.value() + "@"; + const std::string roguelike_name = std::move(roguelike_name_opt.value()) + "@"; const std::string& task = details.get("details", "task", ""); std::string_view task_view = task; if (task_view.starts_with(roguelike_name)) { diff --git a/src/MeoAssistant/Task/Plugin/RoguelikeFormationTaskPlugin.cpp b/src/MeoAssistant/Task/Plugin/RoguelikeFormationTaskPlugin.cpp index b6ea68a417..073d5d67a8 100644 --- a/src/MeoAssistant/Task/Plugin/RoguelikeFormationTaskPlugin.cpp +++ b/src/MeoAssistant/Task/Plugin/RoguelikeFormationTaskPlugin.cpp @@ -19,7 +19,7 @@ bool asst::RoguelikeFormationTaskPlugin::verify(AsstMsg msg, const json::value& if (!roguelike_name_opt) { return false; } - const auto& roguelike_name = roguelike_name_opt.value() + "@"; + const std::string roguelike_name = std::move(roguelike_name_opt.value()) + "@"; const std::string& task = details.get("details", "task", ""); std::string_view task_view = task; if (task_view.starts_with(roguelike_name)) { diff --git a/src/MeoAssistant/Task/Plugin/RoguelikeRecruitTaskPlugin.cpp b/src/MeoAssistant/Task/Plugin/RoguelikeRecruitTaskPlugin.cpp index f1a25e1f94..1370c97a7a 100644 --- a/src/MeoAssistant/Task/Plugin/RoguelikeRecruitTaskPlugin.cpp +++ b/src/MeoAssistant/Task/Plugin/RoguelikeRecruitTaskPlugin.cpp @@ -18,7 +18,7 @@ bool asst::RoguelikeRecruitTaskPlugin::verify(AsstMsg msg, const json::value& de if (!roguelike_name_opt) { return false; } - const auto& roguelike_name = roguelike_name_opt.value() + "@"; + const std::string roguelike_name = std::move(roguelike_name_opt.value()) + "@"; const std::string& task = details.get("details", "task", ""); std::string_view task_view = task; if (task_view.starts_with(roguelike_name)) { diff --git a/src/MeoAssistant/Task/Plugin/RoguelikeResetTaskPlugin.cpp b/src/MeoAssistant/Task/Plugin/RoguelikeResetTaskPlugin.cpp index 0b2e94ed2b..710ee55f9a 100644 --- a/src/MeoAssistant/Task/Plugin/RoguelikeResetTaskPlugin.cpp +++ b/src/MeoAssistant/Task/Plugin/RoguelikeResetTaskPlugin.cpp @@ -12,7 +12,7 @@ bool asst::RoguelikeResetTaskPlugin::verify(AsstMsg msg, const json::value& deta if (!roguelike_name_opt) { return false; } - const auto& roguelike_name = roguelike_name_opt.value() + "@"; + const std::string roguelike_name = std::move(roguelike_name_opt.value()) + "@"; const std::string& task = details.get("details", "task", ""); std::string_view task_view = task; if (task_view.starts_with(roguelike_name)) { diff --git a/src/MeoAssistant/Task/Plugin/RoguelikeShoppingTaskPlugin.cpp b/src/MeoAssistant/Task/Plugin/RoguelikeShoppingTaskPlugin.cpp index 893332a7e5..6dc59fcdb5 100644 --- a/src/MeoAssistant/Task/Plugin/RoguelikeShoppingTaskPlugin.cpp +++ b/src/MeoAssistant/Task/Plugin/RoguelikeShoppingTaskPlugin.cpp @@ -18,7 +18,7 @@ bool asst::RoguelikeShoppingTaskPlugin::verify(AsstMsg msg, const json::value& d if (!roguelike_name_opt) { return false; } - const auto& roguelike_name = roguelike_name_opt.value() + "@"; + const std::string roguelike_name = std::move(roguelike_name_opt.value()) + "@"; const std::string& task = details.get("details", "task", ""); std::string_view task_view = task; if (task_view.starts_with(roguelike_name)) { diff --git a/src/MeoAssistant/Task/Plugin/RoguelikeSkillSelectionTaskPlugin.cpp b/src/MeoAssistant/Task/Plugin/RoguelikeSkillSelectionTaskPlugin.cpp index b9427b5046..21d36c475f 100644 --- a/src/MeoAssistant/Task/Plugin/RoguelikeSkillSelectionTaskPlugin.cpp +++ b/src/MeoAssistant/Task/Plugin/RoguelikeSkillSelectionTaskPlugin.cpp @@ -18,7 +18,7 @@ bool asst::RoguelikeSkillSelectionTaskPlugin::verify(AsstMsg msg, const json::va if (!roguelike_name_opt) { return false; } - const auto& roguelike_name = roguelike_name_opt.value() + "@"; + const std::string roguelike_name = std::move(roguelike_name_opt.value()) + "@"; const std::string& task = details.get("details", "task", ""); std::string_view task_view = task; if (task_view.starts_with(roguelike_name)) {