From fbfc4a6ca15018c745f1bed807b76f4d07928ab2 Mon Sep 17 00:00:00 2001 From: David <56174894+Constrat@users.noreply.github.com> Date: Sun, 22 Oct 2023 12:37:56 +0200 Subject: [PATCH] perf & typo: removed redundant variable & variable typo --- tools/ResourceUpdater/main.cpp | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/tools/ResourceUpdater/main.cpp b/tools/ResourceUpdater/main.cpp index ee7cc9d621..04842170e0 100644 --- a/tools/ResourceUpdater/main.cpp +++ b/tools/ResourceUpdater/main.cpp @@ -896,13 +896,10 @@ bool update_recruitment_data(const std::filesystem::path& input_dir, const std:: auto not_empty = [](Rng str) -> bool { return !str.empty(); }; auto make_string_view = [](Rng str) -> std::string_view { return asst::utils::make_string_view(str); }; - const auto& recruitment_file = input_dir / "gacha_table.json"; - const auto& operators_file = input_dir / "character_table.json"; + auto recruitment_opt = json::open(input_dir / "gacha_table.json"); + auto operators_opt = json::open(input_dir / "character_table.json"); - auto recruitment_opt = json::open(recruitment_file); - auto operatros_opt = json::open(operators_file); - - if (!recruitment_opt || !operatros_opt) { + if (!recruitment_opt || !operators_opt) { std::cerr << "Failed to parse recruitment or operators file" << std::endl; return false; } @@ -943,7 +940,7 @@ bool update_recruitment_data(const std::filesystem::path& input_dir, const std:: std::unordered_map chars_id_list; - for (auto& [id, char_data] : operatros_opt->as_object()) { + for (auto& [id, char_data] : operators_opt->as_object()) { if (is_base) { RecruitmentInfo info; info.rarity = char_data["rarity"].as_integer() + 1;