fz-mirrors/AstrBot
1
0
Fork 0
mirror of https://github.com/AstrBotDevs/AstrBot synced 2026-07-15 17:30:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: address workspace skills review comments

Browse Source
This commit is contained in:
Soulter
2026-06-19 10:52:13 +08:00
parent 6de93fd69f
commit 6fcac65bdf
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
astrbot/core/skills/skill_manager.py
View File

@@ -398,14 +398,14 @@ class SkillManager:
with resolved_skill_md.open(encoding="utf-8") as f:
content = f.read(WORKSPACE_SKILL_FRONTMATTER_MAX_CHARS)
description = _parse_frontmatter_description(content)
except Exception:
except (OSError, UnicodeError):
description = ""
skills.append(
SkillInfo(
name=skill_name,
description=description,
path=str(resolved_skill_md).replace("\\", "/"),
path=resolved_skill_md.as_posix(),
active=True,
source_type="workspace",
source_label="workspace",

20
tests/unit/test_astr_main_agent.py
View File

@@ -818,9 +818,8 @@ class TestEnsurePersonaAndSkills:
encoding="utf-8",
)
workspace_root = (
workspaces_dir
/ module.normalize_umo_for_workspace(mock_event.unified_msg_origin)
workspace_root = workspaces_dir / module.normalize_umo_for_workspace(
mock_event.unified_msg_origin
)
workspace_skill_dir = workspace_root / "skills" / "workspace-skill"
workspace_skill_dir.mkdir(parents=True)
@@ -849,8 +848,11 @@ class TestEnsurePersonaAndSkills:
req = ProviderRequest()
req.conversation = MagicMock(persona_id=None)
runtime_config = {"computer_use_runtime": "local"}
await module._ensure_persona_and_skills(req, {}, mock_context, mock_event)
await module._ensure_persona_and_skills(
req, runtime_config, mock_context, mock_event
)
assert "**workspace-skill**" in req.system_prompt
assert "Workspace scoped skill." in req.system_prompt
@@ -876,9 +878,8 @@ class TestEnsurePersonaAndSkills:
for path in (data_dir, global_skills_dir, plugins_dir):
path.mkdir(parents=True, exist_ok=True)
workspace_root = (
workspaces_dir
/ module.normalize_umo_for_workspace(mock_event.unified_msg_origin)
workspace_root = workspaces_dir / module.normalize_umo_for_workspace(
mock_event.unified_msg_origin
)
workspace_skill_dir = workspace_root / "skills" / "workspace-skill"
workspace_skill_dir.mkdir(parents=True)
@@ -933,9 +934,8 @@ class TestEnsurePersonaAndSkills:
for path in (data_dir, global_skills_dir, plugins_dir):
path.mkdir(parents=True, exist_ok=True)
workspace_root = (
workspaces_dir
/ module.normalize_umo_for_workspace(mock_event.unified_msg_origin)
workspace_root = workspaces_dir / module.normalize_umo_for_workspace(
mock_event.unified_msg_origin
)
workspace_skill_dir = workspace_root / "skills" / "workspace-skill"
workspace_skill_dir.mkdir(parents=True)